aboutsummaryrefslogtreecommitdiffstats
path: root/cgit.h
diff options
context:
space:
mode:
authorGravatar Lars Hjemli <hjemli@gmail.com>2006-12-12 06:53:50 (JST)
committerGravatar Lars Hjemli <hjemli@gmail.com>2006-12-12 06:53:50 (JST)
commitfbaf1171b4e343929dd43ecac7cd9d1c692b84ec (patch)
tree40b7007b2e1e85f2e91e052b33555df2e9fb5e14 /cgit.h
parent44923f8953c66dc9b852316b655ab3b5aec9478e (diff)
downloadcgit-fbaf1171b4e343929dd43ecac7cd9d1c692b84ec.zip
cgit-fbaf1171b4e343929dd43ecac7cd9d1c692b84ec.tar.gz
Don't truncate valid cachefiles
An embarrassing thinko in cgit_check_cache() would truncate valid cachefiles in the following situation: 1) process A notices a missing/expired cachefile 2) process B gets scheduled, locks, fills and unlocks the cachefile 3) process A gets scheduled, locks the cachefile, notices that the cachefile now exist/is not expired anymore, and continues to overwrite it with an empty lockfile. Thanks to Linus for noticing (again). Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to 'cgit.h')
-rw-r--r--cgit.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/cgit.h b/cgit.h
index c1dcc97..c9554a7 100644
--- a/cgit.h
+++ b/cgit.h
@@ -66,6 +66,7 @@ extern int cgit_parse_query(char *txt, configfn fn);
66extern void cache_prepare(struct cacheitem *item); 66extern void cache_prepare(struct cacheitem *item);
67extern int cache_lock(struct cacheitem *item); 67extern int cache_lock(struct cacheitem *item);
68extern int cache_unlock(struct cacheitem *item); 68extern int cache_unlock(struct cacheitem *item);
69extern int cache_cancel_lock(struct cacheitem *item);
69extern int cache_exist(struct cacheitem *item); 70extern int cache_exist(struct cacheitem *item);
70extern int cache_expired(struct cacheitem *item); 71extern int cache_expired(struct cacheitem *item);
71 72