diff options
| -rw-r--r-- | Makefile | 3 | ||||
| -rw-r--r-- | cgit.c | 6 | ||||
| -rw-r--r-- | cgit.css | 40 | ||||
| -rw-r--r-- | cgit.h | 3 | ||||
| -rw-r--r-- | cgitrc.5.txt | 15 | ||||
| -rw-r--r-- | cmd.c | 3 | ||||
| m--------- | git | 0 | ||||
| -rw-r--r-- | html.c | 4 | ||||
| -rw-r--r-- | shared.c | 1 | ||||
| -rw-r--r-- | ui-log.c | 266 | ||||
| -rw-r--r-- | ui-log.h | 3 | ||||
| -rw-r--r-- | ui-summary.c | 2 | ||||
| -rw-r--r-- | vector.c | 38 | ||||
| -rw-r--r-- | vector.h | 17 |
14 files changed, 338 insertions, 63 deletions
| @@ -12,7 +12,7 @@ htmldir = $(docdir) | |||
| 12 | pdfdir = $(docdir) | 12 | pdfdir = $(docdir) |
| 13 | mandir = $(prefix)/share/man | 13 | mandir = $(prefix)/share/man |
| 14 | SHA1_HEADER = <openssl/sha.h> | 14 | SHA1_HEADER = <openssl/sha.h> |
| 15 | GIT_VER = 1.7.3 | 15 | GIT_VER = 1.7.4 |
| 16 | GIT_URL = http://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.bz2 | 16 | GIT_URL = http://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.bz2 |
| 17 | INSTALL = install | 17 | INSTALL = install |
| 18 | MAN5_TXT = $(wildcard *.5.txt) | 18 | MAN5_TXT = $(wildcard *.5.txt) |
| @@ -115,6 +115,7 @@ OBJECTS += ui-stats.o | |||
| 115 | OBJECTS += ui-summary.o | 115 | OBJECTS += ui-summary.o |
| 116 | OBJECTS += ui-tag.o | 116 | OBJECTS += ui-tag.o |
| 117 | OBJECTS += ui-tree.o | 117 | OBJECTS += ui-tree.o |
| 118 | OBJECTS += vector.o | ||
| 118 | 119 | ||
| 119 | ifdef NEEDS_LIBICONV | 120 | ifdef NEEDS_LIBICONV |
| 120 | EXTLIBS += -liconv | 121 | EXTLIBS += -liconv |
| @@ -57,6 +57,8 @@ void repo_config(struct cgit_repo *repo, const char *name, const char *value) | |||
| 57 | repo->defbranch = xstrdup(value); | 57 | repo->defbranch = xstrdup(value); |
| 58 | else if (!strcmp(name, "snapshots")) | 58 | else if (!strcmp(name, "snapshots")) |
| 59 | repo->snapshots = ctx.cfg.snapshots & cgit_parse_snapshots_mask(value); | 59 | repo->snapshots = ctx.cfg.snapshots & cgit_parse_snapshots_mask(value); |
| 60 | else if (!strcmp(name, "enable-commit-graph")) | ||
| 61 | repo->enable_commit_graph = ctx.cfg.enable_commit_graph * atoi(value); | ||
| 60 | else if (!strcmp(name, "enable-log-filecount")) | 62 | else if (!strcmp(name, "enable-log-filecount")) |
| 61 | repo->enable_log_filecount = ctx.cfg.enable_log_filecount * atoi(value); | 63 | repo->enable_log_filecount = ctx.cfg.enable_log_filecount * atoi(value); |
| 62 | else if (!strcmp(name, "enable-log-linecount")) | 64 | else if (!strcmp(name, "enable-log-linecount")) |
| @@ -141,6 +143,8 @@ void config_cb(const char *name, const char *value) | |||
| 141 | ctx.cfg.enable_gitweb_owner = atoi(value); | 143 | ctx.cfg.enable_gitweb_owner = atoi(value); |
| 142 | else if (!strcmp(name, "enable-index-links")) | 144 | else if (!strcmp(name, "enable-index-links")) |
| 143 | ctx.cfg.enable_index_links = atoi(value); | 145 | ctx.cfg.enable_index_links = atoi(value); |
| 146 | else if (!strcmp(name, "enable-commit-graph")) | ||
| 147 | ctx.cfg.enable_commit_graph = atoi(value); | ||
| 144 | else if (!strcmp(name, "enable-log-filecount")) | 148 | else if (!strcmp(name, "enable-log-filecount")) |
| 145 | ctx.cfg.enable_log_filecount = atoi(value); | 149 | ctx.cfg.enable_log_filecount = atoi(value); |
| 146 | else if (!strcmp(name, "enable-log-linecount")) | 150 | else if (!strcmp(name, "enable-log-linecount")) |
| @@ -543,6 +547,8 @@ void print_repo(FILE *f, struct cgit_repo *repo) | |||
| 543 | fprintf(f, "repo.section=%s\n", repo->section); | 547 | fprintf(f, "repo.section=%s\n", repo->section); |
| 544 | if (repo->clone_url) | 548 | if (repo->clone_url) |
| 545 | fprintf(f, "repo.clone-url=%s\n", repo->clone_url); | 549 | fprintf(f, "repo.clone-url=%s\n", repo->clone_url); |
| 550 | fprintf(f, "repo.enable-commit-graph=%d\n", | ||
| 551 | repo->enable_commit_graph); | ||
| 546 | fprintf(f, "repo.enable-log-filecount=%d\n", | 552 | fprintf(f, "repo.enable-log-filecount=%d\n", |
| 547 | repo->enable_log_filecount); | 553 | repo->enable_log_filecount); |
| 548 | fprintf(f, "repo.enable-log-linecount=%d\n", | 554 | fprintf(f, "repo.enable-log-linecount=%d\n", |
| @@ -153,26 +153,44 @@ table.list td { | |||
| 153 | padding: 0.1em 0.5em 0.1em 0.5em; | 153 | padding: 0.1em 0.5em 0.1em 0.5em; |
| 154 | } | 154 | } |
| 155 | 155 | ||
| 156 | table.list td.logsubject { | 156 | table.list td.commitgraph { |
| 157 | font-family: monospace; | 157 | font-family: monospace; |
| 158 | font-weight: bold; | 158 | white-space: pre; |
| 159 | } | 159 | } |
| 160 | 160 | ||
| 161 | table.list td.logmsg { | 161 | table.list td.commitgraph .column1 { |
| 162 | font-family: monospace; | 162 | color: #a00; |
| 163 | white-space: pre; | 163 | } |
| 164 | padding: 1em 0.5em 2em 0.5em; | 164 | |
| 165 | table.list td.commitgraph .column2 { | ||
| 166 | color: #0a0; | ||
| 167 | } | ||
| 168 | |||
| 169 | table.list td.commitgraph .column3 { | ||
| 170 | color: #aa0; | ||
| 165 | } | 171 | } |
| 166 | 172 | ||
| 167 | table.list td.lognotes-label { | 173 | table.list td.commitgraph .column4 { |
| 168 | text-align:right; | 174 | color: #00a; |
| 169 | vertical-align:top; | ||
| 170 | } | 175 | } |
| 171 | 176 | ||
| 172 | table.list td.lognotes { | 177 | table.list td.commitgraph .column5 { |
| 178 | color: #a0a; | ||
| 179 | } | ||
| 180 | |||
| 181 | table.list td.commitgraph .column6 { | ||
| 182 | color: #0aa; | ||
| 183 | } | ||
| 184 | |||
| 185 | table.list td.logsubject { | ||
| 186 | font-family: monospace; | ||
| 187 | font-weight: bold; | ||
| 188 | } | ||
| 189 | |||
| 190 | table.list td.logmsg { | ||
| 173 | font-family: monospace; | 191 | font-family: monospace; |
| 174 | white-space: pre; | 192 | white-space: pre; |
| 175 | padding: 0em 0.5em 2em 0.5em; | 193 | padding: 0 0.5em; |
| 176 | } | 194 | } |
| 177 | 195 | ||
| 178 | table.list td a { | 196 | table.list td a { |
| @@ -20,6 +20,7 @@ | |||
| 20 | #include <xdiff/xdiff.h> | 20 | #include <xdiff/xdiff.h> |
| 21 | #include <utf8.h> | 21 | #include <utf8.h> |
| 22 | #include <notes.h> | 22 | #include <notes.h> |
| 23 | #include <graph.h> | ||
| 23 | 24 | ||
| 24 | 25 | ||
| 25 | /* | 26 | /* |
| @@ -71,6 +72,7 @@ struct cgit_repo { | |||
| 71 | char *section; | 72 | char *section; |
| 72 | char *clone_url; | 73 | char *clone_url; |
| 73 | int snapshots; | 74 | int snapshots; |
| 75 | int enable_commit_graph; | ||
| 74 | int enable_log_filecount; | 76 | int enable_log_filecount; |
| 75 | int enable_log_linecount; | 77 | int enable_log_linecount; |
| 76 | int enable_remote_branches; | 78 | int enable_remote_branches; |
| @@ -188,6 +190,7 @@ struct cgit_config { | |||
| 188 | int enable_filter_overrides; | 190 | int enable_filter_overrides; |
| 189 | int enable_gitweb_owner; | 191 | int enable_gitweb_owner; |
| 190 | int enable_index_links; | 192 | int enable_index_links; |
| 193 | int enable_commit_graph; | ||
| 191 | int enable_log_filecount; | 194 | int enable_log_filecount; |
| 192 | int enable_log_linecount; | 195 | int enable_log_linecount; |
| 193 | int enable_remote_branches; | 196 | int enable_remote_branches; |
diff --git a/cgitrc.5.txt b/cgitrc.5.txt index 1dc3cce..a832830 100644 --- a/cgitrc.5.txt +++ b/cgitrc.5.txt | |||
| @@ -90,7 +90,12 @@ embedded:: | |||
| 90 | Flag which, when set to "1", will make cgit generate a html fragment | 90 | Flag which, when set to "1", will make cgit generate a html fragment |
| 91 | suitable for embedding in other html pages. Default value: none. See | 91 | suitable for embedding in other html pages. Default value: none. See |
| 92 | also: "noheader". | 92 | also: "noheader". |
| 93 | 93 | ||
| 94 | enable-commit-graph:: | ||
| 95 | Flag which, when set to "1", will make cgit print an ASCII-art commit | ||
| 96 | history graph to the left of the commit messages in the repository | ||
| 97 | log page. Default value: "0". | ||
| 98 | |||
| 94 | enable-filter-overrides:: | 99 | enable-filter-overrides:: |
| 95 | Flag which, when set to "1", allows all filter settings to be | 100 | Flag which, when set to "1", allows all filter settings to be |
| 96 | overridden in repository-specific cgitrc files. Default value: none. | 101 | overridden in repository-specific cgitrc files. Default value: none. |
| @@ -362,6 +367,10 @@ repo.defbranch:: | |||
| 362 | repo.desc:: | 367 | repo.desc:: |
| 363 | The value to show as repository description. Default value: none. | 368 | The value to show as repository description. Default value: none. |
| 364 | 369 | ||
| 370 | repo.enable-commit-graph:: | ||
| 371 | A flag which can be used to disable the global setting | ||
| 372 | `enable-commit-graph'. Default value: none. | ||
| 373 | |||
| 365 | repo.enable-log-filecount:: | 374 | repo.enable-log-filecount:: |
| 366 | A flag which can be used to disable the global setting | 375 | A flag which can be used to disable the global setting |
| 367 | `enable-log-filecount'. Default value: none. | 376 | `enable-log-filecount'. Default value: none. |
| @@ -449,6 +458,10 @@ css=/css/cgit.css | |||
| 449 | enable-index-links=1 | 458 | enable-index-links=1 |
| 450 | 459 | ||
| 451 | 460 | ||
| 461 | # Enable ASCII art commit history graph on the log pages | ||
| 462 | enable-commit-graph=1 | ||
| 463 | |||
| 464 | |||
| 452 | # Show number of affected files per commit on the log pages | 465 | # Show number of affected files per commit on the log pages |
| 453 | enable-log-filecount=1 | 466 | enable-log-filecount=1 |
| 454 | 467 | ||
| @@ -67,7 +67,8 @@ static void info_fn(struct cgit_context *ctx) | |||
| 67 | static void log_fn(struct cgit_context *ctx) | 67 | static void log_fn(struct cgit_context *ctx) |
| 68 | { | 68 | { |
| 69 | cgit_print_log(ctx->qry.sha1, ctx->qry.ofs, ctx->cfg.max_commit_count, | 69 | cgit_print_log(ctx->qry.sha1, ctx->qry.ofs, ctx->cfg.max_commit_count, |
| 70 | ctx->qry.grep, ctx->qry.search, ctx->qry.path, 1); | 70 | ctx->qry.grep, ctx->qry.search, ctx->qry.path, 1, |
| 71 | ctx->repo->enable_commit_graph); | ||
| 71 | } | 72 | } |
| 72 | 73 | ||
| 73 | static void ls_cache_fn(struct cgit_context *ctx) | 74 | static void ls_cache_fn(struct cgit_context *ctx) |
diff --git a/git b/git | |||
| Subproject 87b50542a08ac6caa083ddc376e674424e37940 | Subproject 7ed863a85a6ce2c4ac4476848310b8f917ab41f | ||
| @@ -18,7 +18,7 @@ static const char* url_escape_table[256] = { | |||
| 18 | "%00", "%01", "%02", "%03", "%04", "%05", "%06", "%07", "%08", "%09", | 18 | "%00", "%01", "%02", "%03", "%04", "%05", "%06", "%07", "%08", "%09", |
| 19 | "%0a", "%0b", "%0c", "%0d", "%0e", "%0f", "%10", "%11", "%12", "%13", | 19 | "%0a", "%0b", "%0c", "%0d", "%0e", "%0f", "%10", "%11", "%12", "%13", |
| 20 | "%14", "%15", "%16", "%17", "%18", "%19", "%1a", "%1b", "%1c", "%1d", | 20 | "%14", "%15", "%16", "%17", "%18", "%19", "%1a", "%1b", "%1c", "%1d", |
| 21 | "%1e", "%1f", "%20", 0, "%22", "%23", 0, "%25", "%26", "%27", 0, 0, 0, | 21 | "%1e", "%1f", "+", 0, "%22", "%23", 0, "%25", "%26", "%27", 0, 0, 0, |
| 22 | "%2b", 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, "%3c", "%3d", | 22 | "%2b", 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, "%3c", "%3d", |
| 23 | "%3e", "%3f", 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, | 23 | "%3e", "%3f", 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, |
| 24 | 0, 0, 0, 0, 0, 0, 0, 0, 0, "%5c", 0, "%5e", 0, "%60", 0, 0, 0, 0, 0, | 24 | 0, 0, 0, 0, 0, 0, 0, 0, 0, "%5c", 0, "%5e", 0, "%60", 0, 0, 0, 0, 0, |
| @@ -181,7 +181,7 @@ void html_url_arg(const char *txt) | |||
| 181 | const char *e = url_escape_table[c]; | 181 | const char *e = url_escape_table[c]; |
| 182 | if (e) { | 182 | if (e) { |
| 183 | html_raw(txt, t - txt); | 183 | html_raw(txt, t - txt); |
| 184 | html_raw(e, 3); | 184 | html_raw(e, strlen(e)); |
| 185 | txt = t+1; | 185 | txt = t+1; |
| 186 | } | 186 | } |
| 187 | t++; | 187 | t++; |
| @@ -56,6 +56,7 @@ struct cgit_repo *cgit_add_repo(const char *url) | |||
| 56 | ret->section = ctx.cfg.section; | 56 | ret->section = ctx.cfg.section; |
| 57 | ret->defbranch = "master"; | 57 | ret->defbranch = "master"; |
| 58 | ret->snapshots = ctx.cfg.snapshots; | 58 | ret->snapshots = ctx.cfg.snapshots; |
| 59 | ret->enable_commit_graph = ctx.cfg.enable_commit_graph; | ||
| 59 | ret->enable_log_filecount = ctx.cfg.enable_log_filecount; | 60 | ret->enable_log_filecount = ctx.cfg.enable_log_filecount; |
| 60 | ret->enable_log_linecount = ctx.cfg.enable_log_linecount; | 61 | ret->enable_log_linecount = ctx.cfg.enable_log_linecount; |
| 61 | ret->enable_remote_branches = ctx.cfg.enable_remote_branches; | 62 | ret->enable_remote_branches = ctx.cfg.enable_remote_branches; |
| @@ -9,9 +9,25 @@ | |||
| 9 | #include "cgit.h" | 9 | #include "cgit.h" |
| 10 | #include "html.h" | 10 | #include "html.h" |
| 11 | #include "ui-shared.h" | 11 | #include "ui-shared.h" |
| 12 | #include "vector.h" | ||
| 12 | 13 | ||
| 13 | int files, add_lines, rem_lines; | 14 | int files, add_lines, rem_lines; |
| 14 | 15 | ||
| 16 | /* | ||
| 17 | * The list of available column colors in the commit graph. | ||
| 18 | */ | ||
| 19 | static const char *column_colors_html[] = { | ||
| 20 | "<span class='column1'>", | ||
| 21 | "<span class='column2'>", | ||
| 22 | "<span class='column3'>", | ||
| 23 | "<span class='column4'>", | ||
| 24 | "<span class='column5'>", | ||
| 25 | "<span class='column6'>", | ||
| 26 | "</span>", | ||
| 27 | }; | ||
| 28 | |||
| 29 | #define COLUMN_COLORS_HTML_MAX (ARRAY_SIZE(column_colors_html) - 1) | ||
| 30 | |||
| 15 | void count_lines(char *line, int size) | 31 | void count_lines(char *line, int size) |
| 16 | { | 32 | { |
| 17 | if (size <= 0) | 33 | if (size <= 0) |
| @@ -76,27 +92,93 @@ void show_commit_decorations(struct commit *commit) | |||
| 76 | } | 92 | } |
| 77 | } | 93 | } |
| 78 | 94 | ||
| 79 | void print_commit(struct commit *commit) | 95 | void print_commit(struct commit *commit, struct rev_info *revs) |
| 80 | { | 96 | { |
| 81 | struct commitinfo *info; | 97 | struct commitinfo *info; |
| 82 | char *tmp; | 98 | char *tmp; |
| 83 | int cols = 2; | 99 | int cols = revs->graph ? 3 : 2; |
| 100 | struct strbuf graphbuf = STRBUF_INIT; | ||
| 101 | struct strbuf msgbuf = STRBUF_INIT; | ||
| 102 | |||
| 103 | if (ctx.repo->enable_log_filecount) { | ||
| 104 | cols++; | ||
| 105 | if (ctx.repo->enable_log_linecount) | ||
| 106 | cols++; | ||
| 107 | } | ||
| 108 | |||
| 109 | if (revs->graph) { | ||
| 110 | /* Advance graph until current commit */ | ||
| 111 | while (!graph_next_line(revs->graph, &graphbuf)) { | ||
| 112 | /* Print graph segment in otherwise empty table row */ | ||
| 113 | html("<tr class='nohover'><td class='commitgraph'>"); | ||
| 114 | html(graphbuf.buf); | ||
| 115 | htmlf("</td><td colspan='%d' /></tr>\n", cols); | ||
| 116 | strbuf_setlen(&graphbuf, 0); | ||
| 117 | } | ||
| 118 | /* Current commit's graph segment is now ready in graphbuf */ | ||
| 119 | } | ||
| 84 | 120 | ||
| 85 | info = cgit_parse_commit(commit); | 121 | info = cgit_parse_commit(commit); |
| 86 | htmlf("<tr%s><td>", | 122 | htmlf("<tr%s>", ctx.qry.showmsg ? " class='logheader'" : ""); |
| 87 | ctx.qry.showmsg ? " class='logheader'" : ""); | 123 | |
| 88 | tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1)); | 124 | if (revs->graph) { |
| 89 | tmp = cgit_fileurl(ctx.repo->url, "commit", ctx.qry.vpath, tmp); | 125 | /* Print graph segment for current commit */ |
| 90 | html_link_open(tmp, NULL, NULL); | 126 | html("<td class='commitgraph'>"); |
| 91 | cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE); | 127 | html(graphbuf.buf); |
| 92 | html_link_close(); | 128 | html("</td>"); |
| 93 | htmlf("</td><td%s>", | 129 | strbuf_setlen(&graphbuf, 0); |
| 94 | ctx.qry.showmsg ? " class='logsubject'" : ""); | 130 | } |
| 131 | else { | ||
| 132 | html("<td>"); | ||
| 133 | tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1)); | ||
| 134 | tmp = cgit_fileurl(ctx.repo->url, "commit", ctx.qry.vpath, tmp); | ||
| 135 | html_link_open(tmp, NULL, NULL); | ||
| 136 | cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE); | ||
| 137 | html_link_close(); | ||
| 138 | html("</td>"); | ||
| 139 | } | ||
| 140 | |||
| 141 | htmlf("<td%s>", ctx.qry.showmsg ? " class='logsubject'" : ""); | ||
| 142 | if (ctx.qry.showmsg) { | ||
| 143 | /* line-wrap long commit subjects instead of truncating them */ | ||
| 144 | size_t subject_len = strlen(info->subject); | ||
| 145 | |||
| 146 | if (subject_len > ctx.cfg.max_msg_len && | ||
| 147 | ctx.cfg.max_msg_len >= 15) { | ||
| 148 | /* symbol for signaling line-wrap (in PAGE_ENCODING) */ | ||
| 149 | const char wrap_symbol[] = { ' ', 0xE2, 0x86, 0xB5, 0 }; | ||
| 150 | int i = ctx.cfg.max_msg_len - strlen(wrap_symbol); | ||
| 151 | |||
| 152 | /* Rewind i to preceding space character */ | ||
| 153 | while (i > 0 && !isspace(info->subject[i])) | ||
| 154 | --i; | ||
| 155 | if (!i) /* Oops, zero spaces. Reset i */ | ||
| 156 | i = ctx.cfg.max_msg_len - strlen(wrap_symbol); | ||
| 157 | |||
| 158 | /* add remainder starting at i to msgbuf */ | ||
| 159 | strbuf_add(&msgbuf, info->subject + i, subject_len - i); | ||
| 160 | strbuf_trim(&msgbuf); | ||
| 161 | strbuf_add(&msgbuf, "\n\n", 2); | ||
| 162 | |||
| 163 | /* Place wrap_symbol at position i in info->subject */ | ||
| 164 | strcpy(info->subject + i, wrap_symbol); | ||
| 165 | } | ||
| 166 | } | ||
| 95 | cgit_commit_link(info->subject, NULL, NULL, ctx.qry.head, | 167 | cgit_commit_link(info->subject, NULL, NULL, ctx.qry.head, |
| 96 | sha1_to_hex(commit->object.sha1), ctx.qry.vpath, 0); | 168 | sha1_to_hex(commit->object.sha1), ctx.qry.vpath, 0); |
| 97 | show_commit_decorations(commit); | 169 | show_commit_decorations(commit); |
| 98 | html("</td><td>"); | 170 | html("</td><td>"); |
| 99 | html_txt(info->author); | 171 | html_txt(info->author); |
| 172 | |||
| 173 | if (revs->graph) { | ||
| 174 | html("</td><td>"); | ||
| 175 | tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1)); | ||
| 176 | tmp = cgit_fileurl(ctx.repo->url, "commit", ctx.qry.vpath, tmp); | ||
| 177 | html_link_open(tmp, NULL, NULL); | ||
| 178 | cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE); | ||
| 179 | html_link_close(); | ||
| 180 | } | ||
| 181 | |||
| 100 | if (ctx.repo->enable_log_filecount) { | 182 | if (ctx.repo->enable_log_filecount) { |
| 101 | files = 0; | 183 | files = 0; |
| 102 | add_lines = 0; | 184 | add_lines = 0; |
| @@ -110,29 +192,61 @@ void print_commit(struct commit *commit) | |||
| 110 | } | 192 | } |
| 111 | } | 193 | } |
| 112 | html("</td></tr>\n"); | 194 | html("</td></tr>\n"); |
| 113 | if (ctx.qry.showmsg) { | ||
| 114 | struct strbuf notes = STRBUF_INIT; | ||
| 115 | format_note(NULL, commit->object.sha1, ¬es, PAGE_ENCODING, 0); | ||
| 116 | 195 | ||
| 117 | if (ctx.repo->enable_log_filecount) { | 196 | if (revs->graph || ctx.qry.showmsg) { /* Print a second table row */ |
| 118 | cols++; | 197 | html("<tr class='nohover'>"); |
| 119 | if (ctx.repo->enable_log_linecount) | 198 | |
| 120 | cols++; | 199 | if (ctx.qry.showmsg) { |
| 200 | /* Concatenate commit message + notes in msgbuf */ | ||
| 201 | if (info->msg && *(info->msg)) { | ||
| 202 | strbuf_addstr(&msgbuf, info->msg); | ||
| 203 | strbuf_addch(&msgbuf, '\n'); | ||
| 204 | } | ||
| 205 | format_note(NULL, commit->object.sha1, &msgbuf, | ||
| 206 | PAGE_ENCODING, | ||
| 207 | NOTES_SHOW_HEADER | NOTES_INDENT); | ||
| 208 | strbuf_addch(&msgbuf, '\n'); | ||
| 209 | strbuf_ltrim(&msgbuf); | ||
| 121 | } | 210 | } |
| 122 | htmlf("<tr class='nohover'><td/><td colspan='%d' class='logmsg'>", | 211 | |
| 123 | cols); | 212 | if (revs->graph) { |
| 124 | html_txt(info->msg); | 213 | int lines = 0; |
| 125 | html("</td></tr>\n"); | 214 | |
| 126 | if (notes.len != 0) { | 215 | /* Calculate graph padding */ |
| 127 | html("<tr class='nohover'>"); | 216 | if (ctx.qry.showmsg) { |
| 128 | html("<td class='lognotes-label'>Notes:</td>"); | 217 | /* Count #lines in commit message + notes */ |
| 129 | htmlf("<td colspan='%d' class='lognotes'>", | 218 | const char *p = msgbuf.buf; |
| 130 | cols); | 219 | lines = 1; |
| 131 | html_txt(notes.buf); | 220 | while ((p = strchr(p, '\n'))) { |
| 132 | html("</td></tr>\n"); | 221 | p++; |
| 222 | lines++; | ||
| 223 | } | ||
| 224 | } | ||
| 225 | |||
| 226 | /* Print graph padding */ | ||
| 227 | html("<td class='commitgraph'>"); | ||
| 228 | while (lines > 0 || !graph_is_commit_finished(revs->graph)) { | ||
| 229 | if (graphbuf.len) | ||
| 230 | html("\n"); | ||
| 231 | strbuf_setlen(&graphbuf, 0); | ||
| 232 | graph_next_line(revs->graph, &graphbuf); | ||
| 233 | html(graphbuf.buf); | ||
| 234 | lines--; | ||
| 235 | } | ||
| 236 | html("</td>\n"); | ||
| 133 | } | 237 | } |
| 134 | strbuf_release(¬es); | 238 | else |
| 239 | html("<td/>"); /* Empty 'Age' column */ | ||
| 240 | |||
| 241 | /* Print msgbuf into remainder of table row */ | ||
| 242 | htmlf("<td colspan='%d'%s>\n", cols, | ||
| 243 | ctx.qry.showmsg ? " class='logmsg'" : ""); | ||
| 244 | html_txt(msgbuf.buf); | ||
| 245 | html("</td></tr>\n"); | ||
| 135 | } | 246 | } |
| 247 | |||
| 248 | strbuf_release(&msgbuf); | ||
| 249 | strbuf_release(&graphbuf); | ||
| 136 | cgit_free_commitinfo(info); | 250 | cgit_free_commitinfo(info); |
| 137 | } | 251 | } |
| 138 | 252 | ||
| @@ -148,38 +262,94 @@ static const char *disambiguate_ref(const char *ref) | |||
| 148 | return ref; | 262 | return ref; |
| 149 | } | 263 | } |
| 150 | 264 | ||
| 265 | static char *next_token(char **src) | ||
| 266 | { | ||
| 267 | char *result; | ||
| 268 | |||
| 269 | if (!src || !*src) | ||
| 270 | return NULL; | ||
| 271 | while (isspace(**src)) | ||
| 272 | (*src)++; | ||
| 273 | if (!**src) | ||
| 274 | return NULL; | ||
| 275 | result = *src; | ||
| 276 | while (**src) { | ||
| 277 | if (isspace(**src)) { | ||
| 278 | **src = '\0'; | ||
| 279 | (*src)++; | ||
| 280 | break; | ||
| 281 | } | ||
| 282 | (*src)++; | ||
| 283 | } | ||
| 284 | return result; | ||
| 285 | } | ||
| 286 | |||
| 151 | void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern, | 287 | void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern, |
| 152 | char *path, int pager) | 288 | char *path, int pager, int commit_graph) |
| 153 | { | 289 | { |
| 154 | struct rev_info rev; | 290 | struct rev_info rev; |
| 155 | struct commit *commit; | 291 | struct commit *commit; |
| 156 | const char *argv[] = {NULL, NULL, NULL, NULL, NULL}; | 292 | struct vector vec = VECTOR_INIT(char *); |
| 157 | int argc = 2; | ||
| 158 | int i, columns = 3; | 293 | int i, columns = 3; |
| 294 | char *arg; | ||
| 295 | |||
| 296 | /* First argv is NULL */ | ||
| 297 | vector_push(&vec, NULL, 0); | ||
| 159 | 298 | ||
| 160 | if (!tip) | 299 | if (!tip) |
| 161 | tip = ctx.qry.head; | 300 | tip = ctx.qry.head; |
| 162 | 301 | tip = disambiguate_ref(tip); | |
| 163 | argv[1] = disambiguate_ref(tip); | 302 | vector_push(&vec, &tip, 0); |
| 164 | 303 | ||
| 165 | if (grep && pattern && *pattern) { | 304 | if (grep && pattern && *pattern) { |
| 305 | pattern = xstrdup(pattern); | ||
| 166 | if (!strcmp(grep, "grep") || !strcmp(grep, "author") || | 306 | if (!strcmp(grep, "grep") || !strcmp(grep, "author") || |
| 167 | !strcmp(grep, "committer")) | 307 | !strcmp(grep, "committer")) { |
| 168 | argv[argc++] = fmt("--%s=%s", grep, pattern); | 308 | arg = fmt("--%s=%s", grep, pattern); |
| 169 | if (!strcmp(grep, "range")) | 309 | vector_push(&vec, &arg, 0); |
| 170 | argv[1] = pattern; | 310 | } |
| 311 | if (!strcmp(grep, "range")) { | ||
| 312 | /* Split the pattern at whitespace and add each token | ||
| 313 | * as a revision expression. Do not accept other | ||
| 314 | * rev-list options. Also, replace the previously | ||
| 315 | * pushed tip (it's no longer relevant). | ||
| 316 | */ | ||
| 317 | vec.count--; | ||
| 318 | while ((arg = next_token(&pattern))) { | ||
| 319 | if (*arg == '-') { | ||
| 320 | fprintf(stderr, "Bad range expr: %s\n", | ||
| 321 | arg); | ||
| 322 | break; | ||
| 323 | } | ||
| 324 | vector_push(&vec, &arg, 0); | ||
| 325 | } | ||
| 326 | } | ||
| 327 | } | ||
| 328 | if (commit_graph) { | ||
| 329 | static const char *graph_arg = "--graph"; | ||
| 330 | static const char *color_arg = "--color"; | ||
| 331 | vector_push(&vec, &graph_arg, 0); | ||
| 332 | vector_push(&vec, &color_arg, 0); | ||
| 333 | graph_set_column_colors(column_colors_html, | ||
| 334 | COLUMN_COLORS_HTML_MAX); | ||
| 171 | } | 335 | } |
| 172 | 336 | ||
| 173 | if (path) { | 337 | if (path) { |
| 174 | argv[argc++] = "--"; | 338 | arg = "--"; |
| 175 | argv[argc++] = path; | 339 | vector_push(&vec, &arg, 0); |
| 340 | vector_push(&vec, &path, 0); | ||
| 176 | } | 341 | } |
| 342 | |||
| 343 | /* Make sure the vector is NULL-terminated */ | ||
| 344 | vector_push(&vec, NULL, 0); | ||
| 345 | vec.count--; | ||
| 346 | |||
| 177 | init_revisions(&rev, NULL); | 347 | init_revisions(&rev, NULL); |
| 178 | rev.abbrev = DEFAULT_ABBREV; | 348 | rev.abbrev = DEFAULT_ABBREV; |
| 179 | rev.commit_format = CMIT_FMT_DEFAULT; | 349 | rev.commit_format = CMIT_FMT_DEFAULT; |
| 180 | rev.verbose_header = 1; | 350 | rev.verbose_header = 1; |
| 181 | rev.show_root_diff = 0; | 351 | rev.show_root_diff = 0; |
| 182 | setup_revisions(argc, argv, &rev, NULL); | 352 | setup_revisions(vec.count, vec.data, &rev, NULL); |
| 183 | load_ref_decorations(DECORATE_FULL_REFS); | 353 | load_ref_decorations(DECORATE_FULL_REFS); |
| 184 | rev.show_decorations = 1; | 354 | rev.show_decorations = 1; |
| 185 | rev.grep_filter.regflags |= REG_ICASE; | 355 | rev.grep_filter.regflags |= REG_ICASE; |
| @@ -189,8 +359,12 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern | |||
| 189 | if (pager) | 359 | if (pager) |
| 190 | html("<table class='list nowrap'>"); | 360 | html("<table class='list nowrap'>"); |
| 191 | 361 | ||
| 192 | html("<tr class='nohover'><th class='left'>Age</th>" | 362 | html("<tr class='nohover'>"); |
| 193 | "<th class='left'>Commit message"); | 363 | if (commit_graph) |
| 364 | html("<th></th>"); | ||
| 365 | else | ||
| 366 | html("<th class='left'>Age</th>"); | ||
| 367 | html("<th class='left'>Commit message"); | ||
| 194 | if (pager) { | 368 | if (pager) { |
| 195 | html(" ("); | 369 | html(" ("); |
| 196 | cgit_log_link(ctx.qry.showmsg ? "Collapse" : "Expand", NULL, | 370 | cgit_log_link(ctx.qry.showmsg ? "Collapse" : "Expand", NULL, |
| @@ -200,6 +374,8 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern | |||
| 200 | html(")"); | 374 | html(")"); |
| 201 | } | 375 | } |
| 202 | html("</th><th class='left'>Author</th>"); | 376 | html("</th><th class='left'>Author</th>"); |
| 377 | if (commit_graph) | ||
| 378 | html("<th class='left'>Age</th>"); | ||
| 203 | if (ctx.repo->enable_log_filecount) { | 379 | if (ctx.repo->enable_log_filecount) { |
| 204 | html("<th class='left'>Files</th>"); | 380 | html("<th class='left'>Files</th>"); |
| 205 | columns++; | 381 | columns++; |
| @@ -221,7 +397,7 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern | |||
| 221 | } | 397 | } |
| 222 | 398 | ||
| 223 | for (i = 0; i < cnt && (commit = get_revision(&rev)) != NULL; i++) { | 399 | for (i = 0; i < cnt && (commit = get_revision(&rev)) != NULL; i++) { |
| 224 | print_commit(commit); | 400 | print_commit(commit, &rev); |
| 225 | free(commit->buffer); | 401 | free(commit->buffer); |
| 226 | commit->buffer = NULL; | 402 | commit->buffer = NULL; |
| 227 | free_commit_list(commit->parents); | 403 | free_commit_list(commit->parents); |
| @@ -2,7 +2,8 @@ | |||
| 2 | #define UI_LOG_H | 2 | #define UI_LOG_H |
| 3 | 3 | ||
| 4 | extern void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, | 4 | extern void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, |
| 5 | char *pattern, char *path, int pager); | 5 | char *pattern, char *path, int pager, |
| 6 | int commit_graph); | ||
| 6 | extern void show_commit_decorations(struct commit *commit); | 7 | extern void show_commit_decorations(struct commit *commit); |
| 7 | 8 | ||
| 8 | #endif /* UI_LOG_H */ | 9 | #endif /* UI_LOG_H */ |
diff --git a/ui-summary.c b/ui-summary.c index b203bcc..5be2545 100644 --- a/ui-summary.c +++ b/ui-summary.c | |||
| @@ -59,7 +59,7 @@ void cgit_print_summary() | |||
| 59 | if (ctx.cfg.summary_log > 0) { | 59 | if (ctx.cfg.summary_log > 0) { |
| 60 | html("<tr class='nohover'><td colspan='4'> </td></tr>"); | 60 | html("<tr class='nohover'><td colspan='4'> </td></tr>"); |
| 61 | cgit_print_log(ctx.qry.head, 0, ctx.cfg.summary_log, NULL, | 61 | cgit_print_log(ctx.qry.head, 0, ctx.cfg.summary_log, NULL, |
| 62 | NULL, NULL, 0); | 62 | NULL, NULL, 0, 0); |
| 63 | } | 63 | } |
| 64 | if (ctx.repo->clone_url) | 64 | if (ctx.repo->clone_url) |
| 65 | print_urls(ctx.repo->clone_url, NULL); | 65 | print_urls(ctx.repo->clone_url, NULL); |
diff --git a/vector.c b/vector.c new file mode 100644 index 0000000..0863908 --- /dev/null +++ b/vector.c | |||
| @@ -0,0 +1,38 @@ | |||
| 1 | #include <stdio.h> | ||
| 2 | #include <string.h> | ||
| 3 | #include <errno.h> | ||
| 4 | #include "vector.h" | ||
| 5 | |||
| 6 | static int grow(struct vector *vec, int gently) | ||
| 7 | { | ||
| 8 | size_t new_alloc; | ||
| 9 | void *new_data; | ||
| 10 | |||
| 11 | new_alloc = vec->alloc * 3 / 2; | ||
| 12 | if (!new_alloc) | ||
| 13 | new_alloc = 8; | ||
| 14 | new_data = realloc(vec->data, new_alloc * vec->size); | ||
| 15 | if (!new_data) { | ||
| 16 | if (gently) | ||
| 17 | return ENOMEM; | ||
| 18 | perror("vector.c:grow()"); | ||
| 19 | exit(1); | ||
| 20 | } | ||
| 21 | vec->data = new_data; | ||
| 22 | vec->alloc = new_alloc; | ||
| 23 | return 0; | ||
| 24 | } | ||
| 25 | |||
| 26 | int vector_push(struct vector *vec, const void *data, int gently) | ||
| 27 | { | ||
| 28 | int rc; | ||
| 29 | |||
| 30 | if (vec->count == vec->alloc && (rc = grow(vec, gently))) | ||
| 31 | return rc; | ||
| 32 | if (data) | ||
| 33 | memmove(vec->data + vec->count * vec->size, data, vec->size); | ||
| 34 | else | ||
| 35 | memset(vec->data + vec->count * vec->size, 0, vec->size); | ||
| 36 | vec->count++; | ||
| 37 | return 0; | ||
| 38 | } | ||
diff --git a/vector.h b/vector.h new file mode 100644 index 0000000..c64eb1f --- /dev/null +++ b/vector.h | |||
| @@ -0,0 +1,17 @@ | |||
| 1 | #ifndef CGIT_VECTOR_H | ||
| 2 | #define CGIT_VECTOR_H | ||
| 3 | |||
| 4 | #include <stdlib.h> | ||
| 5 | |||
| 6 | struct vector { | ||
| 7 | size_t size; | ||
| 8 | size_t count; | ||
| 9 | size_t alloc; | ||
| 10 | void *data; | ||
| 11 | }; | ||
| 12 | |||
| 13 | #define VECTOR_INIT(type) {sizeof(type), 0, 0, NULL} | ||
| 14 | |||
| 15 | int vector_push(struct vector *vec, const void *data, int gently); | ||
| 16 | |||
| 17 | #endif /* CGIT_VECTOR_H */ | ||
