16 files changed, 381 insertions, 122 deletions

diff --git a/Makefile b/Makefile
index a95a622..036fcd7 100644
--- a/Makefile
+++ b/Makefile
@@ -4,7 +4,7 @@ CGIT_SCRIPT_PATH = /var/www/htdocs/cgit
 CGIT_CONFIG = /etc/cgitrc
 CACHE_ROOT = /var/cache/cgit
 SHA1_HEADER = <openssl/sha.h>
-GIT_VER = 1.6.0.3
+GIT_VER = 1.6.1
 GIT_URL = http://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.bz2
 
 # Define NO_STRCASESTR if you don't have strcasestr.
diff --git a/cgit.c b/cgit.c
index c82587b..d1cee58 100644
--- a/cgit.c
+++ b/cgit.c
@@ -154,6 +154,10 @@ static void querystring_cb(const char *name, const char *value)
                 ctx.qry.name = xstrdup(value);
         } else if (!strcmp(name, "mimetype")) {
                 ctx.qry.mimetype = xstrdup(value);
+        } else if (!strcmp(name, "s")){
+                ctx.qry.sort = xstrdup(value);
+        } else if (!strcmp(name, "showmsg")) {
+                ctx.qry.showmsg = atoi(value);
         }
 }
 
@@ -435,28 +439,29 @@ int main(int argc, const char **argv)
         ctx.repo = NULL;
         http_parse_querystring(ctx.qry.raw, querystring_cb);
 
-        /* If virtual-root isn't specified in cgitrc and no url
-         * parameter is specified on the querystring, lets pretend
-         * that virtualroot equals SCRIPT_NAME and use PATH_INFO as
-         * url. This allows cgit to work with virtual urls without
-         * the need for rewriterules in the webserver (as long as
-         * PATH_INFO is included in the cache lookup key).
+        /* If virtual-root isn't specified in cgitrc, lets pretend
+         * that virtual-root equals SCRIPT_NAME.
          */
-        if (!ctx.cfg.virtual_root && !ctx.qry.url) {
+        if (!ctx.cfg.virtual_root)
                 ctx.cfg.virtual_root = ctx.cfg.script_name;
-                path = getenv("PATH_INFO");
-                if (path) {
-                        if (path[0] == '/')
-                                path++;
-                        ctx.qry.url = xstrdup(path);
-                        if (ctx.qry.raw) {
-                                qry = ctx.qry.raw;
-                                ctx.qry.raw = xstrdup(fmt("%s?%s", path, qry));
-                                free(qry);
-                        } else
-                                ctx.qry.raw = ctx.qry.url;
-                        cgit_parse_url(ctx.qry.url);
-                }
+
+        /* If no url parameter is specified on the querystring, lets
+         * use PATH_INFO as url. This allows cgit to work with virtual
+         * urls without the need for rewriterules in the webserver (as
+         * long as PATH_INFO is included in the cache lookup key).
+         */
+        path = getenv("PATH_INFO");
+        if (!ctx.qry.url && path) {
+                if (path[0] == '/')
+                        path++;
+                ctx.qry.url = xstrdup(path);
+                if (ctx.qry.raw) {
+                        qry = ctx.qry.raw;
+                        ctx.qry.raw = xstrdup(fmt("%s?%s", path, qry));
+                        free(qry);
+                } else
+                        ctx.qry.raw = ctx.qry.url;
+                cgit_parse_url(ctx.qry.url);
         }
 
         ttl = calc_ttl();
diff --git a/cgit.css b/cgit.css
index a37d218..f19446d 100644
--- a/cgit.css
+++ b/cgit.css
@@ -120,6 +120,10 @@ table.list tr {
         background: white;
 }
 
+table.list tr.logheader {
+        background: #eee;
+}
+
 table.list tr:hover {
         background: #eee;
 }
@@ -143,6 +147,17 @@ table.list td {
         padding: 0.1em 0.5em 0.1em 0.5em;
 }
 
+table.list td.logsubject {
+        font-family: monospace;
+        font-weight: bold;
+}
+
+table.list td.logmsg {
+        font-family: monospace;
+        white-space: pre;
+        padding: 1em 0em 2em 0em;
+}
+
 table.list td a {
         color: black;
 }
@@ -456,3 +471,27 @@ div.footer {
         font-size: 80%;
         color: #ccc;
 }
+a.branch-deco {
+        margin: 0px 0.5em;
+        padding: 0px 0.25em;
+        background-color: #88ff88;
+        border: solid 1px #007700;
+}
+a.tag-deco {
+        margin: 0px 0.5em;
+        padding: 0px 0.25em;
+        background-color: #ffff88;
+        border: solid 1px #777700;
+}
+a.remote-deco {
+        margin: 0px 0.5em;
+        padding: 0px 0.25em;
+        background-color: #ccccff;
+        border: solid 1px #000077;
+}
+a.deco {
+        margin: 0px 0.5em;
+        padding: 0px 0.25em;
+        background-color: #ff8888;
+        border: solid 1px #770000;
+}
diff --git a/cgit.h b/cgit.h
index 92f0c5a..cb2f176 100644
--- a/cgit.h
+++ b/cgit.h
@@ -61,6 +61,7 @@ struct cgit_repo {
         int snapshots;
         int enable_log_filecount;
         int enable_log_linecount;
+        time_t mtime;
 };
 
 struct cgit_repolist {
@@ -121,6 +122,8 @@ struct cgit_query {
         char *url;
         int   ofs;
         int nohead;
+        char *sort;
+        int showmsg;
 };
 
 struct cgit_config {
diff --git a/cmd.c b/cmd.c
index 5b3c14c..8914fa5 100644
--- a/cmd.c
+++ b/cmd.c
@@ -104,8 +104,7 @@ static void refs_fn(struct cgit_context *ctx)
 
 static void snapshot_fn(struct cgit_context *ctx)
 {
-        cgit_print_snapshot(ctx->qry.head, ctx->qry.sha1,
-                            cgit_repobasename(ctx->repo->url), ctx->qry.path,
+        cgit_print_snapshot(ctx->qry.head, ctx->qry.sha1, ctx->qry.path,
                             ctx->repo->snapshots, ctx->qry.nohead);
 }
 
diff --git a/git b/git
-Subproject 031e6c898f61db1ae0c0be641eac6532c1000d5
+Subproject 8104ebfe8276657ee803cca7eb8665a78cf3ef8
diff --git a/shared.c b/shared.c
index f5875e4..a764c4d 100644
--- a/shared.c
+++ b/shared.c
@@ -60,6 +60,7 @@ struct cgit_repo *cgit_add_repo(const char *url)
         ret->enable_log_linecount = ctx.cfg.enable_log_linecount;
         ret->module_link = ctx.cfg.module_link;
         ret->readme = NULL;
+        ret->mtime = -1;
         return ret;
 }
 
@@ -266,10 +267,12 @@ int cgit_diff_files(const unsigned char *old_sha1,
         if (!load_mmfile(&file1, old_sha1) || !load_mmfile(&file2, new_sha1))
                 return 1;
 
+        memset(&diff_params, 0, sizeof(diff_params));
+        memset(&emit_params, 0, sizeof(emit_params));
+        memset(&emit_cb, 0, sizeof(emit_cb));
         diff_params.flags = XDF_NEED_MINIMAL;
         emit_params.ctxlen = 3;
         emit_params.flags = XDL_EMIT_FUNCNAMES;
-        emit_params.find_func = NULL;
         emit_cb.outf = filediff_cb;
         emit_cb.priv = fn;
         xdl_diff(&file1, &file2, &diff_params, &emit_params, &emit_cb);
diff --git a/tests/t0107-snapshot.sh b/tests/t0107-snapshot.sh
index d97c465..8ab4912 100755
--- a/tests/t0107-snapshot.sh
+++ b/tests/t0107-snapshot.sh
@@ -4,36 +4,36 @@
 
 prepare_tests "Verify snapshot"
 
-run_test 'get foo/snapshot/test.tar.gz' '
-        cgit_url "foo/snapshot/test.tar.gz" >trash/tmp
+run_test 'get foo/snapshot/master.tar.gz' '
+        cgit_url "foo/snapshot/master.tar.gz" >trash/tmp
 '
 
 run_test 'check html headers' '
         head -n 1 trash/tmp |
-             grep -e "Content-Type: application/x-tar" &&
+             grep -e "Content-Type: application/x-gzip" &&
 
         head -n 2 trash/tmp |
-             grep -e "Content-Disposition: inline; filename=.test.tar.gz."
+             grep -e "Content-Disposition: inline; filename=.master.tar.gz."
 '
 
 run_test 'strip off the header lines' '
-         tail -n +6 trash/tmp > trash/test.tar.gz
+         tail -n +6 trash/tmp > trash/master.tar.gz
 '
 
-run_test 'verify gzip format' 'gunzip --test trash/test.tar.gz'
+run_test 'verify gzip format' 'gunzip --test trash/master.tar.gz'
 run_test 'untar' '
-        rm -rf trash/foo &&
-        tar -xf trash/test.tar.gz -C trash
+        rm -rf trash/master &&
+        tar -xf trash/master.tar.gz -C trash
 '
 
 run_test 'count files' '
-        c=$(ls -1 trash/foo/ | wc -l) &&
+        c=$(ls -1 trash/master/ | wc -l) &&
         test $c = 5
 '
 
 run_test 'verify untarred file-5' '
-         grep -e "^5$" trash/foo/file-5 &&
-         test $(cat trash/foo/file-5 | wc -l) = 1
+         grep -e "^5$" trash/master/file-5 &&
+         test $(cat trash/master/file-5 | wc -l) = 1
 '
 
 tests_done
diff --git a/ui-log.c b/ui-log.c
index d212984..3202848 100644
--- a/ui-log.c
+++ b/ui-log.c
@@ -31,21 +31,57 @@ void inspect_files(struct diff_filepair *pair)
                 cgit_diff_files(pair->one->sha1, pair->two->sha1, count_lines);
 }
 
+void show_commit_decorations(struct commit *commit)
+{
+        struct name_decoration *deco;
+        static char buf[1024];
+
+        buf[sizeof(buf) - 1] = 0;
+        deco = lookup_decoration(&name_decoration, &commit->object);
+        while (deco) {
+                if (!prefixcmp(deco->name, "refs/heads/")) {
+                        strncpy(buf, deco->name + 11, sizeof(buf) - 1);
+                        cgit_log_link(buf, NULL, "branch-deco", buf, NULL, NULL,
+                                0, NULL, NULL, ctx.qry.showmsg);
+                }
+                else if (!prefixcmp(deco->name, "tag: refs/tags/")) {
+                        strncpy(buf, deco->name + 15, sizeof(buf) - 1);
+                        cgit_tag_link(buf, NULL, "tag-deco", ctx.qry.head, buf);
+                }
+                else if (!prefixcmp(deco->name, "refs/remotes/")) {
+                        strncpy(buf, deco->name + 13, sizeof(buf) - 1);
+                        cgit_log_link(buf, NULL, "remote-deco", NULL,
+                                sha1_to_hex(commit->object.sha1), NULL,
+                                0, NULL, NULL, ctx.qry.showmsg);
+                }
+                else {
+                        strncpy(buf, deco->name, sizeof(buf) - 1);
+                        cgit_commit_link(buf, NULL, "deco", ctx.qry.head,
+                                sha1_to_hex(commit->object.sha1));
+                }
+                deco = deco->next;
+        }
+}
+
 void print_commit(struct commit *commit)
 {
         struct commitinfo *info;
         char *tmp;
+        int cols = 2;
 
         info = cgit_parse_commit(commit);
-        html("<tr><td>");
+        htmlf("<tr%s><td>",
+                ctx.qry.showmsg ? " class='logheader'" : "");
         tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1));
         tmp = cgit_pageurl(ctx.repo->url, "commit", tmp);
         html_link_open(tmp, NULL, NULL);
         cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE);
         html_link_close();
-        html("</td><td>");
+        htmlf("</td><td%s>",
+                ctx.qry.showmsg ? " class='logsubject'" : "");
         cgit_commit_link(info->subject, NULL, NULL, ctx.qry.head,
                          sha1_to_hex(commit->object.sha1));
+        show_commit_decorations(commit);
         html("</td><td>");
         html_txt(info->author);
         if (ctx.repo->enable_log_filecount) {
@@ -61,6 +97,17 @@ void print_commit(struct commit *commit)
                 }
         }
         html("</td></tr>\n");
+        if (ctx.qry.showmsg) {
+                if (ctx.repo->enable_log_filecount) {
+                        cols++;
+                        if (ctx.repo->enable_log_linecount)
+                                cols++;
+                }
+                htmlf("<tr class='nohover'><td/><td colspan='%d' class='logmsg'>",
+                        cols);
+                html_txt(info->msg);
+                html("</td></tr>\n");
+        }
         cgit_free_commitinfo(info);
 }
 
@@ -105,6 +152,8 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern
         rev.verbose_header = 1;
         rev.show_root_diff = 0;
         setup_revisions(argc, argv, &rev, NULL);
+        load_ref_decorations();
+        rev.show_decorations = 1;
         rev.grep_filter.regflags |= REG_ICASE;
         compile_grep_patterns(&rev.grep_filter);
         prepare_revision_walk(&rev);
@@ -113,8 +162,16 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern
                 html("<table class='list nowrap'>");
 
         html("<tr class='nohover'><th class='left'>Age</th>"
-             "<th class='left'>Commit message</th>"
-             "<th class='left'>Author</th>");
+              "<th class='left'>Commit message");
+        if (pager) {
+                html(" (");
+                cgit_log_link(ctx.qry.showmsg ? "Collapse" : "Expand", NULL,
+                              NULL, ctx.qry.head, ctx.qry.sha1,
+                              ctx.qry.path, ctx.qry.ofs, ctx.qry.grep,
+                              ctx.qry.search, ctx.qry.showmsg ? 0 : 1);
+                html(")");
+        }
+        html("</th><th class='left'>Author</th>");
         if (ctx.repo->enable_log_filecount) {
                 html("<th class='left'>Files</th>");
                 columns++;
@@ -149,20 +206,20 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern
                         cgit_log_link("[prev]", NULL, NULL, ctx.qry.head,
                                       ctx.qry.sha1, ctx.qry.path,
                                       ofs - cnt, ctx.qry.grep,
-                                      ctx.qry.search);
+                                      ctx.qry.search, ctx.qry.showmsg);
                         html("&nbsp;");
                 }
                 if ((commit = get_revision(&rev)) != NULL) {
                         cgit_log_link("[next]", NULL, NULL, ctx.qry.head,
                                       ctx.qry.sha1, ctx.qry.path,
                                       ofs + cnt, ctx.qry.grep,
-                                      ctx.qry.search);
+                                      ctx.qry.search, ctx.qry.showmsg);
                 }
                 html("</div>");
         } else if ((commit = get_revision(&rev)) != NULL) {
                 html("<tr class='nohover'><td colspan='3'>");
                 cgit_log_link("[...]", NULL, NULL, ctx.qry.head, NULL, NULL, 0,
-                              NULL, NULL);
+                              NULL, NULL, ctx.qry.showmsg);
                 html("</td></tr>\n");
         }
 }
diff --git a/ui-refs.c b/ui-refs.c
index 32e0429..c35e694 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -58,7 +58,8 @@ static int print_branch(struct refinfo *ref)
         if (!info)
                 return 1;
         html("<tr><td>");
-        cgit_log_link(name, NULL, NULL, name, NULL, NULL, 0, NULL, NULL);
+        cgit_log_link(name, NULL, NULL, name, NULL, NULL, 0, NULL, NULL,
+                      ctx.qry.showmsg);
         html("</td><td>");
 
         if (ref->object->type == OBJ_COMMIT) {
@@ -78,12 +79,37 @@ static int print_branch(struct refinfo *ref)
 static void print_tag_header()
 {
         html("<tr class='nohover'><th class='left'>Tag</th>"
-             "<th class='left'>Reference</th>"
+             "<th class='left'>Download</th>"
              "<th class='left'>Author</th>"
              "<th class='left' colspan='2'>Age</th></tr>\n");
         header = 1;
 }
 
+static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
+{
+        const struct cgit_snapshot_format* f;
+        char *filename;
+        const char *basename;
+
+        if (!ref || strlen(ref) < 2)
+                return;
+
+        basename = cgit_repobasename(repo->url);
+        if (prefixcmp(ref, basename) != 0) {
+                if ((ref[0] == 'v' || ref[0] == 'V') && isdigit(ref[1]))
+                        ref++;
+                if (isdigit(ref[0]))
+                        ref = xstrdup(fmt("%s-%s", basename, ref));
+        }
+
+        for (f = cgit_snapshot_formats; f->suffix; f++) {
+                if (!(repo->snapshots & f->bit))
+                        continue;
+                filename = fmt("%s%s", ref, f->suffix);
+                cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename);
+                html("&nbsp;&nbsp;");
+        }
+}
 static int print_tag(struct refinfo *ref)
 {
         struct tag *tag;
@@ -98,7 +124,10 @@ static int print_tag(struct refinfo *ref)
                 html("<tr><td>");