diff options
author | Lars Hjemli <hjemli@gmail.com> | 2008-03-18 07:13:16 (JST) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2008-03-18 07:51:47 (JST) |
commit | e01f1403b9b501c563b1fe0e0052460a95945528 (patch) | |
tree | eff9fd11272714db70bf2ac7116511f03d800af6 /ui-patch.c | |
parent | 0537a7d1cfdf7934d91798a623030fd454b356af (diff) | |
download | cgit-e01f1403b9b501c563b1fe0e0052460a95945528.zip cgit-e01f1403b9b501c563b1fe0e0052460a95945528.tar.gz |
Fix segfault in patch view for root commit
The code for patch view assumed the current commit would always have a parent,
which made cgit segfault when that wasn't the case.
This fixes the bug and adds a test-script for patch view which includes a test
for the inital commit.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to 'ui-patch.c')
-rw-r--r-- | ui-patch.c | 6 |
1 files changed, 5 insertions, 1 deletions
@@ -88,7 +88,11 @@ void cgit_print_patch(char *hex, struct cacheitem *item) | |||
88 | return; | 88 | return; |
89 | } | 89 | } |
90 | info = cgit_parse_commit(commit); | 90 | info = cgit_parse_commit(commit); |
91 | hashcpy(old_sha1, commit->parents->item->object.sha1); | 91 | |
92 | if (commit->parents && commit->parents->item) | ||
93 | hashcpy(old_sha1, commit->parents->item->object.sha1); | ||
94 | else | ||
95 | hashclr(old_sha1); | ||
92 | 96 | ||
93 | patchname = fmt("%s.patch", sha1_to_hex(sha1)); | 97 | patchname = fmt("%s.patch", sha1_to_hex(sha1)); |
94 | cgit_print_snapshot_start("text/plain", patchname, item); | 98 | cgit_print_snapshot_start("text/plain", patchname, item); |