diff options
| author |  Lars Hjemli <hjemli@gmail.com> | 2006-12-12 18:16:41 (JST) |
|---|---|---|
| committer | Lars Hjemli <hjemli@gmail.com> | 2006-12-12 18:16:41 (JST) |
| commit | 58d04f6523b0029281d65f841859fa42d0c744ff (patch) | |
| tree | ed52e95047ccbb99152f7d3f009e57687e6452f1 /ui-commit.c | |
| parent | fbaf1171b4e343929dd43ecac7cd9d1c692b84ec (diff) | |
| download | cgit-58d04f6523b0029281d65f841859fa42d0c744ff.zip cgit-58d04f6523b0029281d65f841859fa42d0c744ff.tar.gz | |
cache_lock: do xstrdup/free on lockfile
Since fmt() uses 8 alternating static buffers, and cache_lock might call
cache_create_dirs() multiple times, which in turn might call fmt() twice,
after four iterations lockfile would be overwritten by a cachedirectory
path.
In worst case, this could cause the cachedirectory to be unlinked and replaced
by a cachefile.
Fix: use xstrdup() on the result from fmt() before assigning to lockfile, and
call free(lockfile) before exit.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to 'ui-commit.c')
0 files changed, 0 insertions, 0 deletions