diff options
author | Lars Hjemli <hjemli@gmail.com> | 2007-12-11 05:47:29 (JST) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-12-11 10:43:24 (JST) |
commit | 620bb3e5e4ff87da740fe7232ba74330b5f862d4 (patch) | |
tree | 152cc090cfc56c387393f6aa6666b9d87ad4a23a | |
parent | afcdd083dab81afef744e261d81a452698188c30 (diff) | |
download | cgit-620bb3e5e4ff87da740fe7232ba74330b5f862d4.zip cgit-620bb3e5e4ff87da740fe7232ba74330b5f862d4.tar.gz |
Add plain patch view
The new view mimics the output from `git format-patch`, making it possible
to cherry-pick directly from cgit with something like `curl $url | git am`.
Inspired by a patch to `git-apply` by Mike Hommey:
http://thread.gmane.org/gmane.comp.version-control.git/67611/focus=67610
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | Makefile | 2 | ||||
-rw-r--r-- | cgit.c | 5 | ||||
-rw-r--r-- | cgit.h | 2 | ||||
-rw-r--r-- | shared.c | 2 | ||||
-rw-r--r-- | ui-patch.c | 105 | ||||
-rw-r--r-- | ui-shared.c | 8 |
6 files changed, 122 insertions, 2 deletions
@@ -16,7 +16,7 @@ GIT_URL = http://www.kernel.org/pub/software/scm/git/git-$(GIT_VER).tar.bz2 | |||
16 | EXTLIBS = git/libgit.a git/xdiff/lib.a -lz -lcrypto | 16 | EXTLIBS = git/libgit.a git/xdiff/lib.a -lz -lcrypto |
17 | OBJECTS = shared.o cache.o parsing.o html.o ui-shared.o ui-repolist.o \ | 17 | OBJECTS = shared.o cache.o parsing.o html.o ui-shared.o ui-repolist.o \ |
18 | ui-summary.o ui-log.o ui-tree.o ui-commit.o ui-diff.o \ | 18 | ui-summary.o ui-log.o ui-tree.o ui-commit.o ui-diff.o \ |
19 | ui-snapshot.o ui-blob.o ui-tag.o ui-refs.o | 19 | ui-snapshot.o ui-blob.o ui-tag.o ui-refs.o ui-patch.o |
20 | 20 | ||
21 | 21 | ||
22 | ifdef NEEDS_LIBICONV | 22 | ifdef NEEDS_LIBICONV |
@@ -75,6 +75,11 @@ static void cgit_print_repo_page(struct cacheitem *item) | |||
75 | return; | 75 | return; |
76 | } | 76 | } |
77 | 77 | ||
78 | if (cgit_cmd == CMD_PATCH) { | ||
79 | cgit_print_patch(cgit_query_sha1, item); | ||
80 | return; | ||
81 | } | ||
82 | |||
78 | if (cgit_cmd == CMD_BLOB) { | 83 | if (cgit_cmd == CMD_BLOB) { |
79 | cgit_print_blob(item, cgit_query_sha1, cgit_query_path); | 84 | cgit_print_blob(item, cgit_query_sha1, cgit_query_path); |
80 | return; | 85 | return; |
@@ -30,6 +30,7 @@ | |||
30 | #define CMD_SNAPSHOT 6 | 30 | #define CMD_SNAPSHOT 6 |
31 | #define CMD_TAG 7 | 31 | #define CMD_TAG 7 |
32 | #define CMD_REFS 8 | 32 | #define CMD_REFS 8 |
33 | #define CMD_PATCH 9 | ||
33 | 34 | ||
34 | /* | 35 | /* |
35 | * Dateformats used on misc. pages | 36 | * Dateformats used on misc. pages |
@@ -283,6 +284,7 @@ extern void cgit_print_commit(char *hex); | |||
283 | extern void cgit_print_refs(); | 284 | extern void cgit_print_refs(); |
284 | extern void cgit_print_tag(char *revname); | 285 | extern void cgit_print_tag(char *revname); |
285 | extern void cgit_print_diff(const char *new_hex, const char *old_hex, const char *prefix); | 286 | extern void cgit_print_diff(const char *new_hex, const char *old_hex, const char *prefix); |
287 | extern void cgit_print_patch(char *hex, struct cacheitem *item); | ||
286 | extern void cgit_print_snapshot(struct cacheitem *item, const char *head, | 288 | extern void cgit_print_snapshot(struct cacheitem *item, const char *head, |
287 | const char *hex, const char *prefix, | 289 | const char *hex, const char *prefix, |
288 | const char *filename, int snapshot); | 290 | const char *filename, int snapshot); |
@@ -70,7 +70,7 @@ int htmlfd = 0; | |||
70 | int cgit_get_cmd_index(const char *cmd) | 70 | int cgit_get_cmd_index(const char *cmd) |
71 | { | 71 | { |
72 | static char *cmds[] = {"log", "commit", "diff", "tree", "blob", | 72 | static char *cmds[] = {"log", "commit", "diff", "tree", "blob", |
73 | "snapshot", "tag", "refs", NULL}; | 73 | "snapshot", "tag", "refs", "patch", NULL}; |
74 | int i; | 74 | int i; |
75 | 75 | ||
76 | for(i = 0; cmds[i]; i++) | 76 | for(i = 0; cmds[i]; i++) |
diff --git a/ui-patch.c b/ui-patch.c new file mode 100644 index 0000000..ef79c7c --- /dev/null +++ b/ui-patch.c | |||
@@ -0,0 +1,105 @@ | |||
1 | /* ui-patch.c: generate patch view | ||
2 | * | ||
3 | * Copyright (C) 2007 Lars Hjemli | ||
4 | * | ||
5 | * Licensed under GNU General Public License v2 | ||
6 | * (see COPYING for full license text) | ||
7 | */ | ||
8 | |||
9 | #include "cgit.h" | ||
10 | |||
11 | static void print_line(char *line, int len) | ||
12 | { | ||
13 | char c = line[len-1]; | ||
14 | |||
15 | line[len-1] = '\0'; | ||
16 | htmlf("%s\n", line); | ||
17 | line[len-1] = c; | ||
18 | } | ||
19 | |||
20 | static void header(unsigned char *sha1, char *path1, int mode1, | ||
21 | unsigned char *sha2, char *path2, int mode2) | ||
22 | { | ||
23 | char *abbrev1, *abbrev2; | ||
24 | int subproject; | ||
25 | |||
26 | subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); | ||
27 | htmlf("diff --git a/%s b/%s\n", path1, path2); | ||
28 | |||
29 | if (is_null_sha1(sha1)) | ||
30 | path1 = "dev/null"; | ||
31 | if (is_null_sha1(sha2)) | ||
32 | path2 = "dev/null"; | ||
33 | |||
34 | if (mode1 == 0) | ||
35 | htmlf("new file mode %.6o\n", mode2); | ||
36 | |||
37 | if (mode2 == 0) | ||
38 | htmlf("deleted file mode %.6o\n", mode1); | ||
39 | |||
40 | if (!subproject) { | ||
41 | abbrev1 = xstrdup(find_unique_abbrev(sha1, DEFAULT_ABBREV)); | ||
42 | abbrev2 = xstrdup(find_unique_abbrev(sha2, DEFAULT_ABBREV)); | ||
43 | htmlf("index %s..%s", abbrev1, abbrev2); | ||
44 | free(abbrev1); | ||
45 | free(abbrev2); | ||
46 | if (mode1 != 0 && mode2 != 0) { | ||
47 | htmlf(" %.6o", mode1); | ||
48 | if (mode2 != mode1) | ||
49 | htmlf("..%.6o", mode2); | ||
50 | } | ||
51 | htmlf("\n--- a/%s\n", path1); | ||
52 | htmlf("+++ b/%s\n", path2); | ||
53 | } | ||
54 | } | ||
55 | |||
56 | static void filepair_cb(struct diff_filepair *pair) | ||
57 | { | ||
58 | header(pair->one->sha1, pair->one->path, pair->one->mode, | ||
59 | pair->two->sha1, pair->two->path, pair->two->mode); | ||
60 | if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { | ||
61 | if (S_ISGITLINK(pair->one->mode)) | ||
62 | print_line(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); | ||
63 | if (S_ISGITLINK(pair->two->mode)) | ||
64 | print_line(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); | ||
65 | return; | ||
66 | } | ||
67 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, print_line)) | ||
68 | html("Error running diff"); | ||
69 | } | ||
70 | |||
71 | void cgit_print_patch(char *hex, struct cacheitem *item) | ||
72 | { | ||
73 | struct commit *commit; | ||
74 | struct commitinfo *info; | ||
75 | unsigned char sha1[20], old_sha1[20]; | ||
76 | char *patchname; | ||
77 | |||
78 | if (!hex) | ||
79 | hex = cgit_query_head; | ||
80 | |||
81 | if (get_sha1(hex, sha1)) { | ||
82 | cgit_print_error(fmt("Bad object id: %s", hex)); | ||
83 | return; | ||
84 | } | ||
85 | commit = lookup_commit_reference(sha1); | ||
86 | if (!commit) { | ||
87 | cgit_print_error(fmt("Bad commit reference: %s", hex)); | ||
88 | return; | ||
89 | } | ||
90 | info = cgit_parse_commit(commit); | ||
91 | hashcpy(old_sha1, commit->parents->item->object.sha1); | ||
92 | |||
93 | patchname = fmt("%s.patch", sha1_to_hex(sha1)); | ||
94 | cgit_print_snapshot_start("text/plain", patchname, item); | ||
95 | htmlf("From %s Mon Sep 17 00:00:00 2001\n", sha1_to_hex(sha1)); | ||
96 | htmlf("From: %s%s\n", info->author, info->author_email); | ||
97 | html("Date: "); | ||
98 | cgit_print_date(info->author_date, "%a, %d %b %Y %H:%M:%S %z%n"); | ||
99 | htmlf("Subject: %s\n\n%s", info->subject, info->msg); | ||
100 | html("---\n"); | ||
101 | cgit_diff_tree(old_sha1, sha1, filepair_cb, NULL); | ||
102 | html("--\n"); | ||
103 | htmlf("cgit %s\n", CGIT_VERSION); | ||
104 | cgit_free_commitinfo(info); | ||
105 | } | ||
diff --git a/ui-shared.c b/ui-shared.c index ece041c..60aa2e3 100644 --- a/ui-shared.c +++ b/ui-shared.c | |||
@@ -272,6 +272,12 @@ void cgit_diff_link(char *name, char *title, char *class, char *head, | |||
272 | html("</a>"); | 272 | html("</a>"); |
273 | } | 273 | } |
274 | 274 | ||
275 | void cgit_patch_link(char *name, char *title, char *class, char *head, | ||
276 | char *rev) | ||
277 | { | ||
278 | reporevlink("patch", name, title, class, head, rev, NULL); | ||
279 | } | ||
280 | |||
275 | void cgit_object_link(struct object *obj) | 281 | void cgit_object_link(struct object *obj) |
276 | { | 282 | { |
277 | char *page, *arg, *url; | 283 | char *page, *arg, *url; |
@@ -490,6 +496,8 @@ void cgit_print_pageheader(char *title, int show_search) | |||
490 | cgit_query_sha1); | 496 | cgit_query_sha1); |
491 | cgit_diff_link("diff", NULL, "menu", cgit_query_head, | 497 | cgit_diff_link("diff", NULL, "menu", cgit_query_head, |
492 | cgit_query_sha1, cgit_query_sha2, NULL); | 498 | cgit_query_sha1, cgit_query_sha2, NULL); |
499 | cgit_patch_link("patch", NULL, "menu", cgit_query_head, | ||
500 | cgit_query_sha1); | ||
493 | 501 | ||
494 | for_each_ref(print_archive_ref, &header); | 502 | for_each_ref(print_archive_ref, &header); |
495 | 503 | ||